Better Mumble Channel Mapping #418
Conversation
|
Can I know what server you're using for this? I'm a bit hesitant to merge this chain as (imo) external servers (that are not FXServer) are kind of a non-priority as they have incompatibilities with listening channels and other things so certain things that pma-voice rely on would inherently not work on those servers |
I'm using pma-voice on a FiveM server with an external Murmur server.
I'm aware of this and am looking into trying out an FXServer to see if it performs any better however I thought I'd do this PR to fix the issue for anyone else that is/decides to use a non-fxserver external server.
Murmur server v1.4.230 and above support listening channels and I've had no issues with them not working. |
|
👍 I'll go ahead and merge this, if theres any reported I'm going to back it out and you can fix and make another PR |
This fixes an issue where if you have an external mumble server (not FXServer) and server IDs go over the max amount of channels that exist, it results in subsequent connections not being assigned a channel.
TDLR of this change is that each player is now assigned to whatever the first free mumble channel is instead of their server id, the current max for the free channel loop is
GetConvarInt('sv_maxclients', 32) + 10for a bit of leniency.